[
https://issues.apache.org/jira/browse/HADOOP-18258?focusedWorklogId=783692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783692
]
ASF GitHub Bot logged work on HADOOP-18258:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/22 04:21
Start Date: 22/Jun/22 04:21
Worklog Time Spent: 10m
Work Description: mehakmeet commented on PR #4383:
URL: https://github.com/apache/hadoop/pull/4383#issuecomment-1162621569
few small nits here
- You have added "." at the end of every line in javadocs, it should only be
at the end of a sentence or end of the javadoc, not each line.
- Some of the methods in AuditTool have wrong access modifiers, if you're
not using a method outside this class just keep them private.
- I have one doubt about putting the auditTool in the Hadoop shell script.
Since, at the moment this is hadoop-aws specific tool, not sure if defining the
command in hadoop-common is the right move. Can you check and see where s3guard
tool's command is defined in hadoop-aws, that might be a more appropriate place
for hadoop-aws specific shell commands.
After these, this LGTM.
CC: @mukund-thakur @steveloughran to review and merge.
Issue Time Tracking
-------------------
Worklog Id: (was: 783692)
Time Spent: 5h 10m (was: 5h)
> Merging of S3A Audit Logs
> -------------------------
>
> Key: HADOOP-18258
> URL: https://issues.apache.org/jira/browse/HADOOP-18258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Sravani Gadey
> Assignee: Sravani Gadey
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Merging audit log files containing huge number of audit logs collected from a
> job like Hive or Spark job containing various S3 requests like list, head,
> get and put requests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
