[
https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784137&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784137
]
ASF GitHub Bot logged work on HADOOP-18304:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 11:07
Start Date: 23/Jun/22 11:07
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4478:
URL: https://github.com/apache/hadoop/pull/4478#discussion_r904889810
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md:
##########
@@ -650,7 +639,14 @@ Conflict management is left to the execution engine itself.
</property>
Review Comment:
Good call out, I had a look and I think that option should actually be just
`fs.s3a.committer.uuid` - no `staging`. I'll update it.
The code in `AbstractS3ACommitter` checks for `fs.s3a.committer.uuid` and
the Spark UUID before failing fast.
https://github.com/apache/hadoop/blob/e199da3fae1c82e87f88c8c50f6a96c6515e2edd/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/AbstractS3ACommitter.java#L1341-L1360
Issue Time Tracking
-------------------
Worklog Id: (was: 784137)
Time Spent: 1h 20m (was: 1h 10m)
> Improve S3A committers documentation clarity
> --------------------------------------------
>
> Key: HADOOP-18304
> URL: https://issues.apache.org/jira/browse/HADOOP-18304
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: documentation
> Reporter: Daniel Carl Jones
> Assignee: Daniel Carl Jones
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I recently was learning more about the S3A committers. I'm hoping to provide
> some improvements as someone who has recently read [this
> documentation|https://github.com/apache/hadoop/blob/1f157f802d2d6142d21482eaa86baf1bef458ed4/hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md#L495]
> without fully understanding prior.
> For instance, referencing different components more explicitly and adding
> pre-requisite info.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
