[
https://issues.apache.org/jira/browse/HADOOP-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191521#comment-13191521
]
Suresh Srinivas commented on HADOOP-7965:
-----------------------------------------
Comments:
# ProtocolInfoProtocol - javadoc says "obtain information about underlying
protocol". Could be specific "to check if a method is supported on the server
side". You could also add information such as, this is used for protocol
compatibility, where a a new client uses new capability if supported on the
server, else falls back to older mechanism. Also clarify that "all method names
unique * for a protocol *"
# Please add javadoc to ProtocolInfoProtocolPB.
# Please add javadoc RpcEngine#getProtocolInfoProtocolProxy(). When unsupported
should the method return null or thrown an exception? For example
WritableRpcEngine returns null.
# It would be better to have a name better than ProtocolInfoProtocol.
# Can you reuse the constructor codes in ProtobufRpcEngine Invoker
# Javadoc missing for class ProtocolInfoProtocolServerSideTranslatorPB
# ProtobufRpcEngine.java has a line > 80 chars
# ServerSideXlator - ClassNotFoundException - Instead of this exception, it may
be better to throw some subclass of IOException?
# RpcClientUtil.java - many lines over 80 chars
# Remove use of VersionedProtocol and related methods in another patch.
# Add some brief comments to tests so that it is easy to understand
> Support for protocol version and signature in PB
> ------------------------------------------------
>
> Key: HADOOP-7965
> URL: https://issues.apache.org/jira/browse/HADOOP-7965
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7965.trunk.combined.patch,
> HADOOP-7965.trunk.combined.patch, HADOOP-7965.trunk.patch,
> HADOOP-7965.trunk.patch
>
>
> VersionedProtocol methods are currently not supported in PB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
