[ 
https://issues.apache.org/jira/browse/HADOOP-17196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560586#comment-17560586
 ] 

Gautham Banasandra edited comment on HADOOP-17196 at 6/29/22 5:27 PM:
----------------------------------------------------------------------

[~iwasakims] The right fix here would be to upgrade to GCC 9 on Centos 7. Here 
are the steps -
1. Run these commands - 
https://github.com/apache/hadoop/blob/2d133a54ac91bb961805915045b6ced2d06801ec/dev-support/docker/Dockerfile_centos_7#L37-L40
2. yum install devtoolset-9
3. Run this command - 
https://github.com/apache/hadoop/blob/2d133a54ac91bb961805915045b6ced2d06801ec/dev-support/docker/Dockerfile_centos_7#L44-L45
4. Set these environment variables - 
https://github.com/apache/hadoop/blob/2d133a54ac91bb961805915045b6ced2d06801ec/dev-support/docker/Dockerfile_centos_7#L48-L61

It would be the responsibility of the downstream projects to align with the 
dependencies of Hadoop, not the other way around. It would be detrimental to 
the evolution of the Hadoop project otherwise.


was (Author: gautham):
[~iwasakims] here's how you can upgrade to GCC 9 on Centos 7 -
1. Run these commands - 
https://github.com/apache/hadoop/blob/2d133a54ac91bb961805915045b6ced2d06801ec/dev-support/docker/Dockerfile_centos_7#L37-L40
2. yum install devtoolset-9
3. Run this command - 
https://github.com/apache/hadoop/blob/2d133a54ac91bb961805915045b6ced2d06801ec/dev-support/docker/Dockerfile_centos_7#L44-L45
4. Set these environment variables - 
https://github.com/apache/hadoop/blob/2d133a54ac91bb961805915045b6ced2d06801ec/dev-support/docker/Dockerfile_centos_7#L48-L61

It would be the responsibility of the downstream projects to align with the 
dependencies of Hadoop, not the other way around. It would be detrimental to 
the evolution of the Hadoop project otherwise.

> Fix C/C++ standard warnings
> ---------------------------
>
>                 Key: HADOOP-17196
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17196
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.1.3
>         Environment: Windows 10 Pro 64-bit
>            Reporter: Gautham Banasandra
>            Assignee: Gautham Banasandra
>            Priority: Major
>             Fix For: 3.2.2, 3.3.1, 3.4.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> The C/C++ language standard is not specified in a cross-compiler manner. Even 
> though it's as straight forward as passing *-std* as compiler arguments, not 
> all the values are supported by all the compilers. For example, compilation 
> with the Visual C++ compiler on Windows with *-std=gnu99* flag causes the 
> following warning -
> {code:java}
> cl : command line warning D9002: ignoring unknown option '-std=gnu99' 
> [Z:\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfs-examples\hdfs_read.vcxproj]
>  {code}
> Thus, we need to use the appropriate flags provided by CMake to specify the 
> C/C++ standards so that it is compiler friendly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to