dannycjones commented on code in PR #4520:
URL: https://github.com/apache/hadoop/pull/4520#discussion_r910945935
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -1573,7 +1560,7 @@ protected S3AReadOpContext createReadContext(
statistics,
statisticsContext,
fileStatus,
- futurePool,
+ unboundedThreadPool,
Review Comment:
Why not the `boundedThreadPool` originally wrapped by `futurePool`?
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AReadOpContext.java:
##########
@@ -18,10 +18,11 @@
package org.apache.hadoop.fs.s3a;
+import java.util.concurrent.ExecutorService;
Review Comment:
There's a `javax.annotation.Nullable` import below Apache. Can you bring it
up to this import?
rel:
https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md#imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
