[ 
https://issues.apache.org/jira/browse/HADOOP-18327?focusedWorklogId=788769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788769
 ]

ASF GitHub Bot logged work on HADOOP-18327:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jul/22 21:07
            Start Date: 07/Jul/22 21:07
    Worklog Time Spent: 10m 
      Work Description: ashutoshcipher opened a new pull request, #4536:
URL: https://github.com/apache/hadoop/pull/4536

   ### Description of PR
   
   Fix eval expression in hadoop-functions.sh
   
   JIRA - HADOOP-18327
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 788769)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix eval expression in hadoop-functions.sh
> ------------------------------------------
>
>                 Key: HADOOP-18327
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18327
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.3.3
>            Reporter: Ashutosh Gupta
>            Assignee: Ashutosh Gupta
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Need to fix the eval expression. We can relace single quote with escape-char 
> and a double quote.
>  
>  HADOOP_OPTS can contain -XX:OnOutOfMemoryError='kill -9 %p', this leads to 
> following invalid eval expression - eval $HADOOP_OPTS='foo_bar 
> -XX:OnOutOfMemoryError='kill -9 %p''
>  Replacing with escape-char and a double quote should works fine.
>  
> eval "$1"="'${!1} $3'" -> eval "$1"="\"${!1} $3\""
>  eval "$1"="'${!1# }'" -> eval "$1"="\"${!1# }\""



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to