[
https://issues.apache.org/jira/browse/HADOOP-18329?focusedWorklogId=789271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789271
]
ASF GitHub Bot logged work on HADOOP-18329:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/22 17:17
Start Date: 09/Jul/22 17:17
Worklog Time Spent: 10m
Work Description: steveloughran commented on code in PR #4537:
URL: https://github.com/apache/hadoop/pull/4537#discussion_r917289045
##########
hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/util/PlatformName.java:
##########
@@ -45,9 +45,34 @@ public class PlatformName {
/**
* A public static variable to indicate the current java vendor is
- * IBM java or not.
+ * IBM and the type is Java Technology Edition which provides its
+ * own implementations of many security packages and Cipher suites.
+ * Note that these are not provided in Semeru runtimes:
+ * See https://developer.ibm.com/languages/java/semeru-runtimes/
*/
- public static final boolean IBM_JAVA = JAVA_VENDOR_NAME.contains("IBM");
+ public static final boolean USE_IBM_JAVA_PACKAGES = shouldUseIbmPackages();
+
+ /*
+ * IBM_JAVA must be preserved due to the public nature of the property.
+ */
+ @Deprecated
+ public static final boolean IBM_JAVA = USE_IBM_JAVA_PACKAGES;
Review Comment:
can't you just leave this as is and so not need to change so many other
files?
##########
hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java:
##########
@@ -38,8 +38,19 @@
import java.util.Arrays;
public class TestMiniKdc extends KerberosSecurityTestcase {
- private static final boolean IBM_JAVA = System.getProperty("java.vendor")
- .contains("IBM");
+ private static final boolean USE_IBM_JAVA_PACKAGES = shouldUseIbmPackages();
Review Comment:
should just use PlatformNames
Issue Time Tracking
-------------------
Worklog Id: (was: 789271)
Remaining Estimate: 0.5h (was: 40m)
Time Spent: 0.5h (was: 20m)
> Add support for IBM Semeru OE JRE 11.0.15.0 and greater
> -------------------------------------------------------
>
> Key: HADOOP-18329
> URL: https://issues.apache.org/jira/browse/HADOOP-18329
> Project: Hadoop Common
> Issue Type: Bug
> Components: auth, common
> Affects Versions: 3.0.0, 3.1.0, 3.0.1, 3.2.0, 3.0.2, 3.1.1, 3.0.3, 3.3.0,
> 3.1.2, 3.2.1, 3.1.3, 3.1.4, 3.2.2, 3.3.1, 3.2.3, 3.3.2, 3.3.3
> Environment: Running Hadoop (or Apache Spark 3.2.1 or above) on IBM
> Semeru runtimes open edition 11.0.15.0 or greater.
> Reporter: Jack
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 1h
> Time Spent: 0.5h
> Remaining Estimate: 0.5h
>
> There are checks within the PlatformName class that use the Vendor property
> of the provided runtime JVM specifically looking for `IBM` within the name.
> Whilst this check worked for IBM's [java technology
> edition|https://www.ibm.com/docs/en/sdk-java-technology] it fails to work on
> [Semeru|https://developer.ibm.com/languages/java/semeru-runtimes/] since
> 11.0.15.0 due to the following change:
> h4. java.vendor system property
> In this release, the {{java.vendor}} system property has been changed from
> "International Business Machines Corporation" to "IBM Corporation".
> Modules such as the below are not provided in these runtimes.
> com.ibm.security.auth.module.JAASLoginModule
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
