[
https://issues.apache.org/jira/browse/HADOOP-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193380#comment-13193380
]
Robert Joseph Evans commented on HADOOP-7993:
---------------------------------------------
Overall the patch looks good to me, btu I do have a few comments.
In your test, it looks like test-config.xml is never deleted. It would be
better if you could use a temp file. That way you don't have to worry about
collisions between files already on disk, and you don't have to worry about the
file going away at the end of the test. Or even better if you could use a
ByteArrayOutputStream instead of writing to a file at all.
In Configuration.handleDeprecation() could you change all calls to LOG.info to
LOG.debug or just to be comments. We don't need to it be printed out every
time we write out a config file. Also it looks like all you need are the
property keys. You might not need to clone the entire property object. Just
call getProps().keys() or getProps().keySet().
> Hadoop ignores old-style config options for enabling compressed output
> ----------------------------------------------------------------------
>
> Key: HADOOP-7993
> URL: https://issues.apache.org/jira/browse/HADOOP-7993
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.1
> Reporter: Anupam Seth
> Assignee: Anupam Seth
> Attachments: HADOOP-7993_branch_0_23.patch
>
>
> Hadoop seems to ignore the config options even though they are printed as
> deprecation warnings in the log: mapred.output.compress and
> mapred.output.compression.codec
> - settings that work on 0.20 but not on 0.23
> mapred.output.compress=true
> mapred.output.compression.codec=org.apache.hadoop.io.compress.BZip2Codec
> - settings that work on 0.23
> mapreduce.output.fileoutputformat.compress=true
> mapreduce.output.fileoutputformat.compress.codec=org.apache.hadoop.io.compress.BZip2Codec
> This breaks backwards compatibility and causes existing jobs to fail.
> This was found to happen due to the JobSubmitter writing out the job.xml file
> with the old-style configs and can be fixed by handdling deprecation before
> the file is written out.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
