PrabhuJoseph commented on code in PR #4546:
URL: https://github.com/apache/hadoop/pull/4546#discussion_r919635071
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/numa/NumaResourceAllocator.java:
##########
@@ -312,6 +312,8 @@ public synchronized void releaseNumaResource(ContainerId
containerId) {
for (NumaNodeResource numaNode : numaNodesList) {
numaNode.releaseResources(containerId);
}
+ // delete from NM State store
+ context.getNMStateStore().releaseAssignedResources(containerId,
NUMA_RESOURCE_TYPE);
Review Comment:
Catch the IOException and throw ResourceHandlerException same as
allocateNumaNodes method.
catch (IOException e) {
throw new ResourceHandlerException(e);
}
And add throws ResourceHandlerException into releaseNumaResource() method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
