iwasakims commented on code in PR #4538:
URL: https://github.com/apache/hadoop/pull/4538#discussion_r919785803
##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/CMakeLists.txt:
##########
@@ -127,7 +127,8 @@ if(OPENSSL_LIBRARY AND OPENSSL_INCLUDE_DIR)
include(CheckCSourceCompiles)
set(OLD_CMAKE_REQUIRED_INCLUDES ${CMAKE_REQUIRED_INCLUDES})
set(CMAKE_REQUIRED_INCLUDES ${OPENSSL_INCLUDE_DIR})
- check_c_source_compiles("#include
\"${OPENSSL_INCLUDE_DIR}/openssl/evp.h\"\nint main(int argc, char **argv) {
return !EVP_aes_256_ctr; }" HAS_NEW_ENOUGH_OPENSSL)
Review Comment:
I see no regression in CMakeOutput.log on my env.
```
$ mvn clean install -DskipTests -DskipShade -Pnative
-Dopenssl.prefix=/usr/local/openssl-1.1.1q
-Dopenssl.lib=/usr/local/openssl-1.1.1q/lib
-Dopenssl.include=/usr/local/openssl-1.1.1q/include -Drequire.openssl
$ grep -B 1 -A 2 evp target/CMakeFiles/CMakeOutput.log
Source file was:
#include <openssl/evp.h>
int main(int argc, char **argv) { return !EVP_aes_256_ctr; }
Performing C++ SOURCE FILE Test THREAD_LOCAL_SUPPORTED succeeded with the
following output:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
