[
https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=791113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-791113
]
ASF GitHub Bot logged work on HADOOP-17461:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/22 19:49
Start Date: 14/Jul/22 19:49
Worklog Time Spent: 10m
Work Description: steveloughran opened a new pull request, #4566:
URL: https://github.com/apache/hadoop/pull/4566
This is PR #4352 with a new patch to integrate with the MR committers, at
least
as far as collecting read stats from job commits and including in _SUCCESS
the committer ITests collect these and print them.
* move reference map and lookup to a IOStatisticsContextIntegration class
* static method in IOStatisticsContext to relay lookup
* add method to switch a thread's context; needed to aggregate worker thread
IO in threads doing work for committers without the need to explicitly
collect and pass back the stats
* production code moves to the new methods
* tests move to this and away from looking up the fields in the streams
* stats are reset in s3a test setup
* s3a committers collect data read stats during job commit and include
in summary statistics. This is only the stats when reading manifest
files, not the actual work.
* tests to print the aggregate of all loaded success files in the run.
### How was this patch tested?
new/modified tests
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
Issue Time Tracking
-------------------
Worklog Id: (was: 791113)
Time Spent: 4h 10m (was: 4h)
> Add thread-level IOStatistics Context
> -------------------------------------
>
> Key: HADOOP-17461
> URL: https://issues.apache.org/jira/browse/HADOOP-17461
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs, fs/azure, fs/s3
> Affects Versions: 3.3.1
> Reporter: Steve Loughran
> Assignee: Mehakmeet Singh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> For effective reporting of the iostatistics of individual worker threads, we
> need a thread-level context which IO components update.
> * this contact needs to be passed in two background thread forming work on
> behalf of a task.
> * IO Components (streams, iterators, filesystems) need to update this context
> statistics as they perform work
> * Without double counting anything.
> I imagine a ThreadLocal IOStatisticContext which will be updated in the
> FileSystem API Calls. This context MUST be passed into the background threads
> used by a task, so that IO is correctly aggregated.
> I don't want streams, listIterators &c to do the updating as there is more
> risk of double counting. However, we need to see their statistics if we want
> to know things like "bytes discarded in backwards seeks". And I don't want to
> be updating a shared context object on every read() call.
> If all we want is store IO (HEAD, GET, DELETE, list performance etc) then the
> FS is sufficient.
> If we do want the stream-specific detail, then I propose
> * caching the context in the constructor
> * updating it only in close() or unbuffer() (as we do from S3AInputStream to
> S3AInstrumenation)
> * excluding those we know the FS already collects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
