steveloughran commented on PR #4566:
URL: https://github.com/apache/hadoop/pull/4566#issuecomment-1185628638

   
   Here are the stats for a magic run where we also measure list calls.
   
   The fact that hsync is being called shows that the terasort output is also 
being picked up. not intentional.
   
   raises a big issue: should these committers reset the context before 
task/job commit.
   
   ```
    commit.AbstractCommitITest (AbstractCommitITest.java:printStatistics(118)) 
- Aggregate job statistics counters=((action_executor_acquired=7)
   (committer_bytes_committed=800042)
   (committer_commit_job=10)
   (committer_commits_completed=14)
   (committer_jobs_completed=10)
   (committer_magic_marker_put=7)
   (committer_materialize_file=14)
   (object_list_request=17)
   (object_multipart_initiated=7)
   (op_hsync=6)
   (stream_write_block_uploads=7)
   (stream_write_bytes=400021)
   (stream_write_total_data=400021));
   
   gauges=();
   
   minimums=((action_executor_acquired.min=0)
   (committer_commit_job.min=301)
   (committer_magic_marker_put.min=70)
   (committer_materialize_file.min=129)
   (object_list_request.min=64)
   (object_multipart_initiated.min=74));
   
   maximums=((action_executor_acquired.max=11)
   (committer_commit_job.max=643)
   (committer_magic_marker_put.max=127)
   (committer_materialize_file.max=478)
   (object_list_request.max=319)
   (object_multipart_initiated.max=97));
   
   means=((action_executor_acquired.mean=(samples=14, sum=65, mean=4.6429))
   (committer_commit_job.mean=(samples=10, sum=4974, mean=497.4000))
   (committer_magic_marker_put.mean=(samples=7, sum=641, mean=91.5714))
   (committer_materialize_file.mean=(samples=14, sum=3171, mean=226.5000))
   (object_list_request.mean=(samples=17, sum=2098, mean=123.4118))
   (object_multipart_initiated.mean=(samples=7, sum=598, mean=85.4286)));
   ```
   
   this is going to overreport, but i don't think the committers should be 
interfering with the context which should really be managed by the app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to