GauthamBanasandra opened a new pull request, #4571:
URL: https://github.com/apache/hadoop/pull/4571
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
While building dynamic libraries (.dll) on Windows, there's a constraint
that all the dependent libraries be linked dynamically. This poses an issue
since Protobuf (which is an HDFS native client dependency) runs into build
issues when linked dynamically. There are a few [warning
notes](https://github.com/protocolbuffers/protobuf/blob/9ebb31726cef11e4e940b50ec751df4e863e3d2a/cmake/README.md#dlls-vs-static-linking)
on the Protobuf repository's build instructions page as well.
Thus, to keep things simple, we can resort to do only static linking and
thereby only produce statically linked libraries on Windows. In summary, we'll
be providing only Hadoop .lib files initially. We can aim to produce Hadoop DLL
on Windows eventually once we're able to resolve Protobuf's DLL issues.
### How was this patch tested?
Hadoop Jenkins CI validation ensures that the Linux components aren't
affected. Verified that the static library is produced as a result of
successful build on my local Windows system.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
