KevinWikant commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1187587395
Yetus failing because no new unit test was added: ``` The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. ``` Note that this change was unit tested via the existing test "TestDecommission#testDeleteCorruptReplicaForUnderReplicatedBlock", the only caveat is that this unit test is behaving differently when backporting [HDFS-16064](https://issues.apache.org/jira/browse/HDFS-16064) to older Hadoop versions, which is what caused this bug to be discovered in the first place. See the section "Why does unit test failure not reproduce in Hadoop trunk?" in [HDFS-16664](https://issues.apache.org/jira/browse/HDFS-16664) for additional details on difference in behavior. In summary: - on trunk the corrupt block replicas are invalidated immediately when first block report is sent - on branch-3.2.1 the corrupt block replica invalidation is getting postponed for some reason Need additional time to investigate this difference in behavior, if possible I will try to make the unit test behavior more consistent Can also add some unit testing to new code in CorruptReplicasMap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
