[
https://issues.apache.org/jira/browse/HADOOP-18348?focusedWorklogId=792550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792550
]
ASF GitHub Bot logged work on HADOOP-18348:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/22 09:51
Start Date: 19/Jul/22 09:51
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4589:
URL: https://github.com/apache/hadoop/pull/4589#issuecomment-1188845501
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 40m 51s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 37s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 23s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 5s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 1m 23s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 3s | | No new issues. |
| +1 :green_heart: | shadedclient | 22m 12s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 47s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 43s | | The patch does not
generate ASF License warnings. |
| | | 95m 1s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4589/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4589 |
| Optional Tests | dupname asflicense mvnsite unit codespell detsecrets
shellcheck shelldocs |
| uname | Linux 89d937a0ab5d 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 6ae157228cb7719583747c9247ce4770d6aa0fd5 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4589/1/testReport/ |
| Max. process+thread count | 633 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4589/1/console |
| versions | git=2.25.1 maven=3.6.3 shellcheck=0.7.0 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
Issue Time Tracking
-------------------
Worklog Id: (was: 792550)
Time Spent: 20m (was: 10m)
> Echo java process's parent pid to the pid file intermediate state
> -----------------------------------------------------------------
>
> Key: HADOOP-18348
> URL: https://issues.apache.org/jira/browse/HADOOP-18348
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Reporter: jiangrui
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In hadoop-function.sh file，there is hadoop_start_daemon and
> hadoop_start_daemon_wrapper functions.
> hadoop_start_daemon_wrapper invoke hadoop_start_daemon and put it to
> background.
>
> In hadoop_start_daemon function, echo $$ > pidfile，cause this scenario
> because hadoop_start_daemon is in a subshell by ampersand, and $ expands to
> the process ID of the current shell, not the subshell.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
