ahmarsuhail commented on PR #4458:
URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1189301358

   @steveloughran by 
   
   > can you split success/failure logging of the invocation and duration of 
calls
   
   do you mean to add in stats for number of failed prefetch ops & duration of 
this failure? for duration, I couldn't figure out how to measure failure..for 
example, the duration of reading from S3 is measured 
[here](https://github.com/apache/hadoop/pull/4458/files#diff-79d7c6565dcf3633d045b1222349326646bfa722d8441ca1e9939b72df38161cR109),
 if the operation fails, the duration tracker will call `tracker.failed();`. 
   
   1) What does tracker.failed() do?
   2) how should this be changed to measure duration of a failure?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to