ferhui commented on code in PR #4529:
URL: https://github.com/apache/hadoop/pull/4529#discussion_r926223561
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -3152,15 +3152,17 @@ public void run() {
IOUtils.cleanupWithLogger(LOG, traceScope);
if (call != null) {
updateMetrics(call, startTimeNanos, connDropped);
- ProcessingDetails.LOG.debug(
Review Comment:
@aajisaka mentioned on other PRs.
> If the log level is not debug, toString() is not actually called.
> http://www.slf4j.org/faq.html#logging_performance
So it is unnecessary that add isDebugEnabled here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
