mehakmeet commented on PR #4352:
URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1192316937
Pushed the changes, makes sense in case of null IOStatisticsContext. There
is one more issue, in case we have `fs.thread.level.iostatistics.enabled=false`
which means empty counters, hence the test getting failed in the test in this
PR only, since it requires thread-level IOstatsitics to be enabled, now we do
the `removeBaseAndBucketOverrides(configuration,
THREAD_LEVEL_IOSTATISTICS_ENABLED);
configuration.setBoolean(THREAD_LEVEL_IOSTATISTICS_ENABLED, true);`
But, since the way this is toggled is in a static initializer for the
`IOStatisticsContextIntegration` utility class, it does it's calculation before
this, and setting it afterwards doesn't have an affect, how do we ensure that
this property is enabled for this test always? Reload the class using
classLoaders(not sure if this works since I tried using the
Thread.currentThread.getClassLoaderContext)?
Also
> Contributed by Mehakmeet Singh
*and Steve Loughran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
