steveloughran commented on PR #4458:
URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1192857372
not sure why one of the runs didn't pick up the tracker null checks. looks
like there's an indentation to fix in one file
```
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:28:
public final class EmptyPrefetchingStatistics implements PrefetchingStatistics
{: 'class def modifier' has incorrect indentation level 1, expected level
should be 0. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:30:
private static final EmptyPrefetchingStatistics EMPTY_PREFETCHING_STATISTICS
=: 'member def modifier' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:33:
private EmptyPrefetchingStatistics() {: 'ctor def modifier' has incorrect
indentation level 3, expected level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:34:
}: 'ctor def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:36:
public static EmptyPrefetchingStatistics getInstance() {: 'method def
modifier' has incorrect indentation level 3, expected level should be 2.
[Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:37:
return EMPTY_PREFETCHING_STATISTICS;: 'method def' child has incorrect
indentation level 5, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:38:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:40:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:42:
return stubDurationTracker();: 'method def' child has incorrect
indentation level 5, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:43:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:45:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:48:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:50:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:53:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:55:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:58:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:60:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:63:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:65:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:68:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:70:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:73:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:74:
}: 'class def rcurly' has incorrect indentation level 1, expected level should
be 0. [Indentation]
```
i think once those are done we can declare victory and merge, though the
stream will need to support IOStatisticsContext after the next rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
