[
https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=794352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794352
]
ASF GitHub Bot logged work on HADOOP-18190:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/22 19:03
Start Date: 22/Jul/22 19:03
Worklog Time Spent: 10m
Work Description: steveloughran commented on PR #4458:
URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1192857372
not sure why one of the runs didn't pick up the tracker null checks. looks
like there's an indentation to fix in one file
```
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:28:
public final class EmptyPrefetchingStatistics implements PrefetchingStatistics
{: 'class def modifier' has incorrect indentation level 1, expected level
should be 0. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:30:
private static final EmptyPrefetchingStatistics EMPTY_PREFETCHING_STATISTICS
=: 'member def modifier' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:33:
private EmptyPrefetchingStatistics() {: 'ctor def modifier' has incorrect
indentation level 3, expected level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:34:
}: 'ctor def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:36:
public static EmptyPrefetchingStatistics getInstance() {: 'method def
modifier' has incorrect indentation level 3, expected level should be 2.
[Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:37:
return EMPTY_PREFETCHING_STATISTICS;: 'method def' child has incorrect
indentation level 5, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:38:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:40:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:42:
return stubDurationTracker();: 'method def' child has incorrect
indentation level 5, expected level should be 4. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:43:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:45:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:48:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:50:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:53:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:55:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:58:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:60:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:63:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:65:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:68:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:70:
@Override: 'method def modifier' has incorrect indentation level 3, expected
level should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:73:
}: 'method def rcurly' has incorrect indentation level 3, expected level
should be 2. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/common/EmptyPrefetchingStatistics.java:74:
}: 'class def rcurly' has incorrect indentation level 1, expected level should
be 0. [Indentation]
```
i think once those are done we can declare victory and merge, though the
stream will need to support IOStatisticsContext after the next rebase
Issue Time Tracking
-------------------
Worklog Id: (was: 794352)
Time Spent: 3h 20m (was: 3h 10m)
> s3a prefetching streams to collect iostats on prefetching operations
> --------------------------------------------------------------------
>
> Key: HADOOP-18190
> URL: https://issues.apache.org/jira/browse/HADOOP-18190
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> There is a lot more happening in reads, so there's a lot more data to collect
> and publish in IO stats for us to view in a summary at the end of processes
> as well as get from the stream while it is active.
> Some useful ones would seem to be:
> counters
> * is in memory. using 0 or 1 here lets aggregation reports count total #of
> memory cached files.
> * prefetching operations executed
> * errors during prefetching
> gauges
> * number of blocks in cache
> * total size of blocks
> * active prefetches
> + active memory used
> duration tracking count/min/max/ave
> * time to fetch a block
> * time queued before the actual fetch begins
> * time a reader is blocked waiting for a block fetch to complete
> and some info on cache use itself
> * number of blocks discarded unread
> * number of prefetched blocks later used
> * number of backward seeks to a prefetched block
> * number of forward seeks to a prefetched block
> the key ones I care about are
> # memory consumption
> # can we determine if cache is working (reads with cache hit) and when it is
> not (misses, wasted prefetches)
> # time blocked on executors
> The stats need to be accessible on a stream even when closed, and aggregated
> into the FS. once we get per-thread stats contexts we can publish there too
> and collect in worker threads for reporting in task commits
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
