goiri commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r928287817
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj.filters:
##########
@@ -48,19 +46,16 @@
<ClCompile Include="src\org\apache\hadoop\util\NativeCodeLoader.c">
<Filter>Source Files</Filter>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\lz4.c">
- <Filter>Source Files</Filter>
- </ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\lz4hc.c">
+ <ClCompile
Include="src\org\apache\hadoop\security\JniBasedUnixGroupsMappingWin.c">
<Filter>Source Files</Filter>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\Lz4Compressor.c">
+ <ClCompile
Include="src\org\apache\hadoop\io\compress\zlib\ZlibCompressor.c">
Review Comment:
Why are we changing this?
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review Comment:
What was the old number and where was it defined?
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -142,16 +140,16 @@
<ClCompile Include="src\org\apache\hadoop\io\erasurecode\isal_load.c"
Condition="'$(IsalEnabled)' == 'true'">
<AdditionalOptions>/D
HADOOP_ISAL_LIBRARY=L\"isa-l.dll\"</AdditionalOptions>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\erasure_code.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\gf_util.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\erasure_coder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\dump.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile
Include="src\org\apache\hadoop\io\erasurecode\jni_erasure_code_native.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\jni_common.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\jni_rs_encoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\jni_rs_decoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile
Include="src\org\apache\hadoop\io\erasurecode\jni_xor_encoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile
Include="src\org\apache\hadoop\io\erasurecode\jni_xor_decoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
+ <ClCompile Include="src\org\apache\hadoop\io\erasurecode\erasure_code.c"
Condition="'$(IsalEnabled)' == 'true'" />
Review Comment:
Can we avoid these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
