slfan1989 commented on code in PR #4618:
URL: https://github.com/apache/hadoop/pull/4618#discussion_r928353496
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -675,53 +662,47 @@ public GetApplicationsResponse
getApplications(GetApplicationsRequest request)
throws YarnException, IOException {
if (request == null) {
routerMetrics.incrMultipleAppsFailedRetrieved();
- RouterServerUtil.logAndThrowException(
- "Missing getApplications request.",
- null);
+ RouterServerUtil.logAndThrowException("Missing getApplications
request.", null);
}
long startTime = clock.getTime();
Map<SubClusterId, SubClusterInfo> subclusters =
federationFacade.getSubClusters(true);
ClientMethod remoteMethod = new ClientMethod("getApplications",
new Class[] {GetApplicationsRequest.class}, new Object[] {request});
- Map<SubClusterId, GetApplicationsResponse> applications;
-
+ Map<SubClusterId, GetApplicationsResponse> applications = null;
try {
applications = invokeConcurrent(subclusters.keySet(), remoteMethod,
GetApplicationsResponse.class);
-
} catch (Exception ex) {
routerMetrics.incrMultipleAppsFailedRetrieved();
- LOG.error("Unable to get applications due to exception.", ex);
- throw ex;
+ RouterServerUtil.logAndThrowException("Unable to get applications due to
exception.", ex);
}
long stopTime = clock.getTime();
routerMetrics.succeededMultipleAppsRetrieved(stopTime - startTime);
// Merge the Application Reports
- return RouterYarnClientUtils.mergeApplications(applications.values(),
- returnPartialReport);
+ return RouterYarnClientUtils.mergeApplications(applications.values(),
returnPartialReport);
}
@Override
public GetClusterMetricsResponse getClusterMetrics(
GetClusterMetricsRequest request) throws YarnException, IOException {
+ if (request == null) {
+ routerMetrics.incrGetClusterMetricsFailedRetrieved();
+ RouterServerUtil.logAndThrowException("Missing getClusterMetrics
request.", null);
+ }
long startTime = clock.getTime();
- Map<SubClusterId, SubClusterInfo> subclusters =
+ Map<SubClusterId, SubClusterInfo> subClusters =
Review Comment:
I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
