slfan1989 commented on code in PR #4314:
URL: https://github.com/apache/hadoop/pull/4314#discussion_r928788350
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/AppReportFetcher.java:
##########
@@ -112,51 +87,74 @@ protected ApplicationHistoryProtocol
getAHSProxy(Configuration configuration)
* @throws YarnException on any error.
* @throws IOException
*/
- public FetchedAppReport getApplicationReport(ApplicationId appId)
- throws YarnException, IOException {
- GetApplicationReportRequest request = recordFactory
- .newRecordInstance(GetApplicationReportRequest.class);
+ public abstract FetchedAppReport getApplicationReport(ApplicationId appId)
+ throws YarnException, IOException;
+
+ /**
+ * Get an application report for the specified application id from the RM and
+ * fall back to the Application History Server if not found in RM.
+ *
+ * @param applicationsManager what to use to get the RM reports.
+ * @param appId id of the application to get.
+ * @return the ApplicationReport for the appId.
+ * @throws YarnException on any error.
+ * @throws IOException connection exception.
+ */
+ protected FetchedAppReport getApplicationReport(ApplicationClientProtocol
applicationsManager,
+ ApplicationId appId)
Review Comment:
indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
