9uapaw commented on PR #4622: URL: https://github.com/apache/hadoop/pull/4622#issuecomment-1194109589
Hi @K0K0V0K, thank you for taking this task. I have some comments on the approach: - Wildcarding should not be exposed to ConfigurationProperties (I have not fully checked whether something breaks there, but we should keep it as simple as possible) - In theory it is possible to come up with an algorithm that handles wildcarding with explicit queue parts in between (like root.*.a.*), but I think it is done with backtracking and it is not a very efficient one. - That being said I believe we should encourage templating for dynamic queues only, which makes *.a.* kind paths a bad practice. My opinion is to narrow the scope down to support full wildcard queue paths (eg. root.*.* or root.*.*.*) only. We can revisit it later if there is a demand for a more intelligent approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
