KevinWikant commented on PR #4563:
URL: https://github.com/apache/hadoop/pull/4563#issuecomment-1194540951
@PrabhuJoseph I have addressed all the checkstyle issues except for the
SaslRpcClient Indentation issue which, as I mentioned, would result in
inconsistent indentation if addressed:
```
case KERBEROS: {
if (ugi.getRealAuthenticationMethod().getAuthMethod() !=
AuthMethod.KERBEROS) {
LOG.debug("client isn't using kerberos");
return null;
}
final String serverPrincipal;
try {
serverPrincipal = getServerPrincipal(authType);
} catch (IllegalArgumentException ex) {
// YARN-11210: getServerPrincipal can throw IllegalArgumentException
if Kerberos
// configuration is bad, this is surfaced as a non-retryable
SaslException
throw new SaslException("Bad Kerberos server principal
configuration", ex);
}
if (serverPrincipal == null) {
LOG.debug("protocol doesn't use kerberos");
return null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
