[
https://issues.apache.org/jira/browse/HADOOP-18368?focusedWorklogId=795279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795279
]
ASF GitHub Bot logged work on HADOOP-18368:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/22 13:48
Start Date: 26/Jul/22 13:48
Worklog Time Spent: 10m
Work Description: ahmarsuhail opened a new pull request, #4634:
URL: https://github.com/apache/hadoop/pull/4634
### Description of PR
Jira: https://issues.apache.org/jira/browse/HADOOP-18368
ITestCustomSigner was failing for access point names that had '-', eg:
test-custom-signer. This PR updates the logic so access point name is now
extracted using substring. Eg, if `bucketName = test-custom-signer-12345678`
where `12345678` is the aws account id, we can get access point name by
`bucketName.substring(0, bucketName.length() - (accountId.length() + 1))`, with
the `+ 1` being for removing the`-` before the account id.
### How was this patch tested?
Since it's only updating the `ITestCustomSigner`, I tested by
running`ITestCustomSigner` with:
- Access point name test-custom-signer
- Access point name testcustomsigner
- Access points disabled
Issue Time Tracking
-------------------
Worklog Id: (was: 795279)
Remaining Estimate: 0h
Time Spent: 10m
> ITestCustomSigner fails when access point name has '-'
> -------------------------------------------------------
>
> Key: HADOOP-18368
> URL: https://issues.apache.org/jira/browse/HADOOP-18368
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ahmar Suhail
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If you create an access point name which has hyphens, eg
> custom-signer-access-point, the ITestCustomSigner fails. This is because the
> array is split on "-"
> [here|https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestCustomSigner.java#L231]
> and then joined, so access point name becomes "customsigneraccesspoint".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
