goiri commented on code in PR #4633:
URL: https://github.com/apache/hadoop/pull/4633#discussion_r930260394
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Quota.java:
##########
@@ -204,7 +204,8 @@ QuotaUsage getGlobalQuota(String path) throws IOException {
* @return {@code true} if path is a mount entry; {@code false} otherwise.
*/
private boolean isMountEntry(String path) {
Review Comment:
Can we add a unit test?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Quota.java:
##########
@@ -204,7 +204,8 @@ QuotaUsage getGlobalQuota(String path) throws IOException {
* @return {@code true} if path is a mount entry; {@code false} otherwise.
*/
private boolean isMountEntry(String path) {
- return router.getQuotaManager().isMountEntry(path);
+ return router.isQuotaEnabled() &&
Review Comment:
This can be a single line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
