[
https://issues.apache.org/jira/browse/HADOOP-18372?focusedWorklogId=795651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795651
]
ASF GitHub Bot logged work on HADOOP-18372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/22 13:09
Start Date: 27/Jul/22 13:09
Worklog Time Spent: 10m
Work Description: steveloughran commented on code in PR #4642:
URL: https://github.com/apache/hadoop/pull/4642#discussion_r931039984
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:
##########
@@ -30,6 +30,8 @@
import java.util.concurrent.ExecutorService;
import com.amazonaws.services.s3.model.DeleteObjectsRequest;
+
+import org.apache.hadoop.fs.store.audit.AuditSpan;
Review Comment:
this should go into the main o.a.h imports. it getting in here because the
Preconditions class is where guava is. cherrypicking is a lot easier if imports
avoid this area
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:
##########
@@ -144,26 +146,24 @@ public ILoadTestS3ABulkDeleteThrottling(
@Override
protected Configuration createScaleConfiguration() {
Configuration conf = super.createScaleConfiguration();
- S3ATestUtils.disableFilesystemCaching(conf);
- return conf;
- }
- @Override
- public void setup() throws Exception {
- final Configuration conf = getConf();
S3ATestUtils.removeBaseAndBucketOverrides(conf,
EXPERIMENTAL_AWS_INTERNAL_THROTTLING,
BULK_DELETE_PAGE_SIZE,
USER_AGENT_PREFIX);
Review Comment:
should add ENABLE_MULTI_DELETE here
Issue Time Tracking
-------------------
Worklog Id: (was: 795651)
Time Spent: 0.5h (was: 20m)
> ILoadTestS3ABulkDeleteThrottling failing
> ----------------------------------------
>
> Key: HADOOP-18372
> URL: https://issues.apache.org/jira/browse/HADOOP-18372
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Ahmar Suhail
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> the test ILoadTestS3ABulkDeleteThrottling; looks like the fs config is being
> set up too late in the test suite. it should be moved from setup to createConf
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
