[
https://issues.apache.org/jira/browse/HADOOP-18227?focusedWorklogId=795770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795770
]
ASF GitHub Bot logged work on HADOOP-18227:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/22 17:27
Start Date: 27/Jul/22 17:27
Worklog Time Spent: 10m
Work Description: steveloughran commented on code in PR #4636:
URL: https://github.com/apache/hadoop/pull/4636#discussion_r931322342
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java:
##########
@@ -60,9 +60,9 @@ public abstract class AbstractContractVectoredReadTest
extends AbstractFSContrac
protected static final byte[] DATASET =
ContractTestUtils.dataset(DATASET_LEN, 'a', 32);
protected static final String VECTORED_READ_FILE_NAME = "vectored_file.txt";
- private final IntFunction<ByteBuffer> allocate;
+ protected final IntFunction<ByteBuffer> allocate;
Review Comment:
keep private and add getters
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInstrumentation.java:
##########
@@ -835,6 +839,10 @@ private InputStreamStatistics(
StreamStatisticNames.STREAM_READ_SEEK_BYTES_DISCARDED,
StreamStatisticNames.STREAM_READ_SEEK_BYTES_SKIPPED,
StreamStatisticNames.STREAM_READ_TOTAL_BYTES,
+ StreamStatisticNames.STREAM_READ_VECTORED_OPERATIONS,
Review Comment:
can you keep in alphabetical order
Issue Time Tracking
-------------------
Worklog Id: (was: 795770)
Time Spent: 40m (was: 0.5h)
> Add input stream IOstats for vectored IO api in S3A.
> ----------------------------------------------------
>
> Key: HADOOP-18227
> URL: https://issues.apache.org/jira/browse/HADOOP-18227
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Mukund Thakur
> Assignee: Mukund Thakur
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
