goiri commented on code in PR #4657:
URL: https://github.com/apache/hadoop/pull/4657#discussion_r933857815
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java:
##########
@@ -58,11 +60,39 @@ public NodeIDsInfo(List<String> nodeIdsList, Resource
resource) {
this.partitionInfo = new PartitionInfo(new ResourceInfo(resource));
}
+ public NodeIDsInfo(Set<String> nodeIdsList, PartitionInfo partitionInfo) {
+ this.nodeIDsList.addAll(new ArrayList<>(nodeIdsList));
Review Comment:
Do we need to create an array? Isn't addAll based on Collection?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java:
##########
@@ -58,11 +60,39 @@ public NodeIDsInfo(List<String> nodeIdsList, Resource
resource) {
this.partitionInfo = new PartitionInfo(new ResourceInfo(resource));
}
+ public NodeIDsInfo(Set<String> nodeIdsList, PartitionInfo partitionInfo) {
+ this.nodeIDsList.addAll(new ArrayList<>(nodeIdsList));
+ this.partitionInfo = partitionInfo;
+ }
+
public ArrayList<String> getNodeIDs() {
return nodeIDsList;
}
public PartitionInfo getPartitionInfo() {
return partitionInfo;
}
+
+ public static NodeIDsInfo add(NodeIDsInfo left, NodeIDsInfo right) {
Review Comment:
javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
