9uapaw commented on code in PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#discussion_r934578071


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java:
##########
@@ -531,6 +531,9 @@ public float 
getMaximumApplicationMasterResourcePerQueuePercent(String queue) {
                getMaximumApplicationMasterResourcePercent());
   }
 
+  public boolean 
isMaximumApplicationMasterResourcePerQueuePercentPresent(String queue) {

Review Comment:
   isMaximumApplicationMasterResourcePerQueuePercentSet would be a better name 
for this.



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java:
##########
@@ -742,6 +745,10 @@ public float getUserLimitFactor(String queue) {
     return userLimitFactor;
   }
 
+  public boolean isUserLimitFactorPresent(String queue) {

Review Comment:
   Same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to