monthonk opened a new pull request, #4669:
URL: https://github.com/apache/hadoop/pull/4669

   ### Description of PR
   
   HADOOP-18339. S3A storage class option only picked up when buffering writes 
to disk.
   
   The problem is that there are two `createPutObjectRequest` classes, one for 
source file and another one for input stream. Previously, only the first one is 
picking up storage class option because I thought the second one is used only 
by creating directory marker which should not have any storage class.
   
   This is fixed it by making both of `createPutObjectRequest` classes pick up 
the storage class option and updating `newDirectoryMarkerRequest` to create PUT 
request on its own then add parameterized test to verify it.
   
   ### How was this patch tested?
   
   Tested with a bucket in `eu-west-1` with `mvn -Dparallel-tests 
-DtestsThreadCount=16 clean verify`
   
   ```
   [INFO] Results:
   [INFO] 
   [WARNING] Tests run: 1149, Failures: 0, Errors: 0, Skipped: 146
   
   [INFO] Results:
   [INFO] 
   [WARNING] Tests run: 124, Failures: 0, Errors: 0, Skipped: 10
   ```
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [x] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to