goiri commented on code in PR #4665:
URL: https://github.com/apache/hadoop/pull/4665#discussion_r934770189
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1580,7 +1580,7 @@ private void acquirePermit(final String nsId, final
UserGroupInformation ugi,
// Throw StandByException,
// Clients could fail over and try another router.
if (rpcMonitor != null) {
- rpcMonitor.getRPCMetrics().incrProxyOpPermitRejected();
Review Comment:
Should we keep the old method too?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcMonitor.java:
##########
@@ -74,7 +74,17 @@ void init(
* exception.
*/
void proxyOpFailureCommunicate(String nsId);
+
+ /**
+ * Rejected to proxy an operation to a Namenode.
+ */
+ void ProxyOpPermitRejected(String nsId);
Review Comment:
lower case p?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1590,6 +1590,9 @@ private void acquirePermit(final String nsId, final
UserGroupInformation ugi,
" is overloaded for NS: " + nsId;
throw new StandbyException(msg);
}
+ if (rpcMonitor!= null) {
Review Comment:
spacing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
