ashutoshcipher commented on code in PR #4658:
URL: https://github.com/apache/hadoop/pull/4658#discussion_r935105525
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java:
##########
@@ -98,8 +98,7 @@ protected static <T> T createRMProxy(final Configuration
configuration,
YarnConfiguration conf = (configuration instanceof YarnConfiguration)
? (YarnConfiguration) configuration
: new YarnConfiguration(configuration);
- RetryPolicy retryPolicy = createRetryPolicy(conf,
- (HAUtil.isHAEnabled(conf) ||
HAUtil.isFederationFailoverEnabled(conf)));
+ RetryPolicy retryPolicy = createRetryPolicy(conf, isFailoverEnabled(conf));
Review Comment:
@goiri - I have updated the test `testProxyProvider` as part this change.
Are you recommending to add unit test case for `isFailoverEnabled` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
