goiri commented on code in PR #4659:
URL: https://github.com/apache/hadoop/pull/4659#discussion_r936047891
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##########
@@ -2070,6 +2077,46 @@ public void testSetBalancerBandwidth() throws Exception {
}, 100, 60 * 1000);
}
+ @Test
+ public void testRecordRealClient() throws Exception {
Review Comment:
Does it make sense to refactor this into a general function and call it with
the two configs?
The other interesting part would be to log the output too.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java:
##########
@@ -121,6 +121,44 @@ public String toString() {
return str;
}
+ private static String parseSpecialValue(String content, String key) {
+ int posn = content.indexOf(key);
Review Comment:
Small javadoc with an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
