[
https://issues.apache.org/jira/browse/HADOOP-18364?focusedWorklogId=797495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797495
]
ASF GitHub Bot logged work on HADOOP-18364:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/22 04:34
Start Date: 03/Aug/22 04:34
Worklog Time Spent: 10m
Work Description: zhangshuyan0 commented on code in PR #4624:
URL: https://github.com/apache/hadoop/pull/4624#discussion_r936226138
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java:
##########
@@ -1128,4 +1131,13 @@ public void testEditLogTailing() throws Exception {
}
}
+ @Test
Review Comment:
Sure.
Issue Time Tracking
-------------------
Worklog Id: (was: 797495)
Time Spent: 2h 10m (was: 2h)
> All method metrics related to the rpc protocol should be initialized
> --------------------------------------------------------------------
>
> Key: HADOOP-18364
> URL: https://issues.apache.org/jira/browse/HADOOP-18364
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Shuyan Zhang
> Assignee: Shuyan Zhang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When an RPC protocol is used, the metric of protocol-related methods should
> be initialized; otherwise, metric information will be incomplete. For
> example, when we call HAServiceProtocol#monitorHealth(), only the metric of
> monitorHealth() are initialized, and the metric of transitionToStandby() are
> still not reported. This incompleteness caused a little trouble for our
> monitoring system.
> The root cause is that the parameter passed by RpcEngine to
> MutableRatesWithAggregation#init(java.lang.Class<?>) is always
> XXXProtocolPB, which is inherited from BlockingInterface and does not
> implement any methods. We should fix this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
