slfan1989 commented on code in PR #4695:
URL: https://github.com/apache/hadoop/pull/4695#discussion_r937372323


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/MockDefaultRequestInterceptorREST.java:
##########
@@ -412,4 +419,50 @@ public Response signalToContainer(String containerId, 
String command,
 
     return Response.status(Status.OK).build();
   }
+
+  @Override
+  public org.apache.hadoop.yarn.server.webapp.dao.AppAttemptInfo 
getAppAttempt(HttpServletRequest req, HttpServletResponse res,

Review Comment:
   I found 2 conflicts
   
   org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAttemptInfo
   org.apache.hadoop.yarn.server.webapp.dao.AppAttemptInfo
   
   MockDefaultRequestInterceptorREST#getAppAttempts, I will use whole type.
   ```
   public AppAttemptsInfo getAppAttempts(HttpServletRequest hsr, String appId) {
       if (!isRunning) {
         throw new RuntimeException("RM is stopped");
       }
   
       ApplicationId applicationId = ApplicationId.fromString(appId);
       if (!applicationMap.contains(applicationId)) {
         throw new NotFoundException("app with id: " + appId + " not found");
       }
   
       AppAttemptsInfo infos = new AppAttemptsInfo();
       org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAttemptInfo
            appAttemptInfo1 = new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAttemptInfo();
       infos.add(appAttemptInfo1);
   
       return infos;
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to