steveloughran commented on code in PR #4690:
URL: https://github.com/apache/hadoop/pull/4690#discussion_r938659885
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockOperations.java:
##########
@@ -163,61 +163,61 @@ private synchronized Operation add(Operation op) {
public Operation getPrefetched(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
- return this.add(new Operation(Kind.GET_PREFETCHED, blockNumber));
+ return add(new Operation(Kind.GET_PREFETCHED, blockNumber));
}
public Operation getCached(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
- return this.add(new Operation(Kind.GET_CACHED, blockNumber));
+ return add(new Operation(Kind.GET_CACHED, blockNumber));
}
public Operation getRead(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
- return this.add(new Operation(Kind.GET_READ, blockNumber));
+ return add(new Operation(Kind.GET_READ, blockNumber));
}
public Operation release(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
Review Comment:
missed that. will do. fwiw i do like this precondition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
