[
https://issues.apache.org/jira/browse/HADOOP-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575685#comment-17575685
]
ASF GitHub Bot commented on HADOOP-18181:
-----------------------------------------
steveloughran commented on code in PR #4690:
URL: https://github.com/apache/hadoop/pull/4690#discussion_r938659885
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockOperations.java:
##########
@@ -163,61 +163,61 @@ private synchronized Operation add(Operation op) {
public Operation getPrefetched(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
- return this.add(new Operation(Kind.GET_PREFETCHED, blockNumber));
+ return add(new Operation(Kind.GET_PREFETCHED, blockNumber));
}
public Operation getCached(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
- return this.add(new Operation(Kind.GET_CACHED, blockNumber));
+ return add(new Operation(Kind.GET_CACHED, blockNumber));
}
public Operation getRead(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
- return this.add(new Operation(Kind.GET_READ, blockNumber));
+ return add(new Operation(Kind.GET_READ, blockNumber));
}
public Operation release(int blockNumber) {
Validate.checkNotNegative(blockNumber, "blockNumber");
Review Comment:
missed that. will do. fwiw i do like this precondition.
> move org.apache.hadoop.fs.common package into hadoop-common module
> -------------------------------------------------------------------
>
> Key: HADOOP-18181
> URL: https://issues.apache.org/jira/browse/HADOOP-18181
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> move org.apache.hadoop.fs.common package from hadoop-aws, along with any
> tests, into hadoop-common jar and the+ package org.apache.hadoop.fs.impl
> (except for any bits we find are broadly useful in applications to use any
> new APIs, in which case somewhere more public, such as o.a.h.util.functional
> for the futures work)
> we can and should pick on new package and move the classes there, even while
> they are in hadoop-aws. why so? lets us add checkstyle/findbugs rules with
> the final classnames
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
