steveloughran commented on PR #4383:
URL: https://github.com/apache/hadoop/pull/4383#issuecomment-1206709133
this isn't a bug, just inefficient, as the instanceof is always false if the
argument is null.
because this is generated code, it's not something which can be fixed. so
instead we tell it to ignore this possible bug NP_NULL_INSTANCEOF
1. edit the file hadoop-tools/hadoop-aws/dev-support/findbugs-exclude.xml
2. under the bottom match entry, add an XML element to tell spotbugs to be
quiet
```xml
<Match>
<Class name="org.apache.hadoop.fs.s3a.audit.AvroDataRecord"/>
<Bug pattern="NP_NULL_INSTANCEOF"/>
</Match>
```
you can check the module without having to wait for yetus to do it.
```bash
mvn spotbugs:spotbugs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
