[ 
https://issues.apache.org/jira/browse/HADOOP-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196349#comment-13196349
 ] 

Todd Lipcon commented on HADOOP-7983:
-------------------------------------

+1, looks good. The only suggestion I have is that, rather than always making 
the host:port the first argument to the fence script, it would be better to use 
a substitution token. That is to say, the user would configure "myfence.sh 
$TARGETHOST foo bar" and Hadoop would substitute the target. This would allow 
use of pre-existing scripts that might have a different ordering of arguments 
without a wrapper. If you want to do this as a followup, that's fine.
                
> HA: failover should be able to pass args to fencers
> ---------------------------------------------------
>
>                 Key: HADOOP-7983
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7983
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: HA Branch (HDFS-1623)
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-7983.txt, hadoop-7983.txt
>
>
> Currently fencing method args are passed in the config (eg 
> "sshfence(host1,8022)" indicates to fence the service running on port 8022 on 
> host1. The target service to fence should be determined by the failover (we 
> fence the currently active service) not configured statically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to