virajjasani commented on PR #4722:
URL: https://github.com/apache/hadoop/pull/4722#issuecomment-1209772369
> back when we did that the sts client shutdown just threw
UnsupportedOperationException. is that no longer the case? if so, we should
stop swallowing it in our STSClient
That is true, we no longer need to catch `UnsupportedOperationException`.
Based on the implementations that implement `AWSSecurityTokenService`, it seems
that this Exception is now only thrown by `AbstractAWSSecurityTokenService`,
which we don't use anyways.
`AbstractAWSSecurityTokenService`:
```
@Override
public void shutdown() {
throw new java.lang.UnsupportedOperationException();
}
```
`AWSSecurityTokenServiceAsyncClient`:
```
@Override
public void shutdown() {
super.shutdown();
executorService.shutdownNow();
}
```
`AWSSecurityTokenServiceClient`:
```
@Override
public void shutdown() {
super.shutdown();
}
```
We are good here. Just ran all the tests against new commit. Sharing the
test results in the next comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
