[
https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577585#comment-17577585
]
ASF GitHub Bot commented on HADOOP-18373:
-----------------------------------------
virajjasani commented on PR #4705:
URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1209781608
> what was it? test running as other user?
Basically for this test, I manually did the `sts assume-role` and then
retrieved session token with `aws sts get-session-token` and also added this
token to auth-keys, this was the root cause behind
`ITestS3ATemporaryCredentials#testSTS` failure because calling GetSessionToken
with session credentials (including session token) would not allow user to
retrieve temporary creds. Besides, I also kept
`fs.s3a.aws.credentials.provider` as `TemporaryAWSCredentialsProvider`. After
bit of digging, when I realized that temporary credential provider cannot call
the above API with session token, I removed session token and also removed
`fs.s3a.aws.credentials.provider` to let the credential providers be picked up
by default. After this change, test went smooth.
> fwiw i use a very restricted user/role for my s3 tests, so if that key
ever leaked, it would limit the damage to accessing my test s3 buckets, assume
one role, etc. not even start an EC2 vm
Ah yes, this is definitely very good suggestion, thanks!
> IOStatisticsContext tuning
> --------------------------
>
> Key: HADOOP-18373
> URL: https://issues.apache.org/jira/browse/HADOOP-18373
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.3.9
> Reporter: Steve Loughran
> Assignee: Viraj Jasani
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.3.9
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Tuning of the IOStatisticsContext code
> h2. change property name to fs.iostatistics....
> there are other fs.iostatistics options, the new one needs consistent naming
> h2. enable in hadoop-aws
> edit core-site.xml in hadoop-aws/test/resources to always collect context
> iOStatistics
> This helps qualify the code
> {code}
> <property>
> <name>fs.thread.level.iostatistics.enabled</name>
> <value>true</value>
> </property>
> {code}
> h3. IOStatisticsContext to add add static probe to see if it is enabled.
> lets apps know not to bother collecting/reporting
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
