goiri commented on code in PR #4701:
URL: https://github.com/apache/hadoop/pull/4701#discussion_r941833661
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
##########
@@ -513,6 +524,25 @@ public Map<String, SubClusterPolicyConfiguration> invoke(
return cacheRequest;
}
+ private Object buildGetApplicationHomeSubClusterRequest(ApplicationId
applicationId) {
+ final String cacheKey = buildCacheKey(getClass().getSimpleName(),
+ GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, applicationId.toString());
+ CacheRequest<String, SubClusterId> cacheRequest = new CacheRequest<>(
+ cacheKey,
+ input -> {
+ GetApplicationHomeSubClusterResponse response =
+ stateStore.getApplicationHomeSubCluster(
+
GetApplicationHomeSubClusterRequest.newInstance(applicationId));
Review Comment:
Extract to req
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
##########
@@ -513,6 +524,25 @@ public Map<String, SubClusterPolicyConfiguration> invoke(
return cacheRequest;
}
+ private Object buildGetApplicationHomeSubClusterRequest(ApplicationId
applicationId) {
+ final String cacheKey = buildCacheKey(getClass().getSimpleName(),
+ GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, applicationId.toString());
+ CacheRequest<String, SubClusterId> cacheRequest = new CacheRequest<>(
+ cacheKey,
+ input -> {
+ GetApplicationHomeSubClusterResponse response =
+ stateStore.getApplicationHomeSubCluster(
+
GetApplicationHomeSubClusterRequest.newInstance(applicationId));
+
+ ApplicationHomeSubCluster applicationHomeSubCluster =
Review Comment:
appHomeSubCluster and one line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
