[
https://issues.apache.org/jira/browse/HADOOP-18398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577987#comment-17577987
]
ASF GitHub Bot commented on HADOOP-18398:
-----------------------------------------
hadoop-yetus commented on PR #4727:
URL: https://github.com/apache/hadoop/pull/4727#issuecomment-1210679006
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 38s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 47s | | trunk passed |
| +1 :green_heart: | compile | 23m 8s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 45s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | mvnsite | 2m 13s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 45s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 22s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 108m 0s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 3s | | the patch passed |
| +1 :green_heart: | compile | 24m 11s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 24m 11s | | the patch passed |
| +1 :green_heart: | compile | 22m 30s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 22m 30s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 1m 57s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 27s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 7s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 29m 56s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 19m 14s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 34s | | The patch does not
generate ASF License warnings. |
| | | 209m 16s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4727/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4727 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | Linux 82415a672676 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 517c0bac48ada1f1ce3f44371b4b8ddb96662523 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4727/1/testReport/ |
| Max. process+thread count | 1292 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4727/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Prevent AvroRecord*.class from being included non-test jar
> ----------------------------------------------------------
>
> Key: HADOOP-18398
> URL: https://issues.apache.org/jira/browse/HADOOP-18398
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.3.3, 3.3.4
> Reporter: YUBI LEE
> Priority: Major
> Labels: pull-request-available
>
> bq.
> {code}
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.BanDuplicateClasses
> failed with message:
> Duplicate classes found:
> Found in:
> org.apache.hadoop:hadoop-client-minicluster:jar:3.3.4:compile
> org.apache.hadoop:hadoop-client-api:jar:3.3.4:compile
> Duplicate classes:
> org/apache/hadoop/io/serializer/avro/AvroRecord.class
> org/apache/hadoop/io/serializer/avro/AvroRecord$Builder.class
> org/apache/hadoop/io/serializer/avro/AvroRecord$1.class
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce
> (enforce-banned-dependencies) on project hadoop-client-check-test-invariants:
> Some Enforcer rules have failed. Look above for specific messages explaining
> why the rule failed. -> [Help 1]
> {code}
> When building Hadoop, AvroRecord*.class are included in hadoop-client-api jar
> and I think it is wrong.
> It is caused by "protobuf-maven-plugin" as a side effect.
> https://github.com/apache/hadoop/blob/rel/release-3.3.4/hadoop-common-project/hadoop-common/pom.xml#L1118
> {code:xml}
> <execution>
> <id>src-test-compile-protoc-legacy</id>
> <phase>generate-test-sources</phase>
> <goals>
> <goal>compile</goal>
> </goals>
> <configuration>
> <skip>false</skip>
> <!--Generating with old protobuf version for backward
> compatibility-->
> <protocArtifact>
>
> com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}
> </protocArtifact>
>
> <includeDependenciesInDescriptorSet>false</includeDependenciesInDescriptorSet>
> <protoSourceRoot>${basedir}/src/test/proto</protoSourceRoot>
>
> <outputDirectory>${project.build.directory}/generated-test-sources/java</outputDirectory>
> <clearOutputDirectory>false</clearOutputDirectory>
> <includes>
> <include>test_legacy.proto</include>
> <include>test_rpc_service_legacy.proto</include>
> </includes>
> </configuration>
> </execution>
> {code}
> "src-test-compile-protoc-legacy" 's goal is written "compile" wrongly. It
> makes outputDirectory
> (${project.build.directory}/generated-test-sources/java) to be added to
> "compileSourceRoots" of maven-compiler-plugin.
> "src-test-compile-protoc-legacy" 's goal should be "test-compile".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
