goiri commented on code in PR #4314:
URL: https://github.com/apache/hadoop/pull/4314#discussion_r944610371
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java:
##########
@@ -361,8 +362,8 @@ public void testAppReportForEmptyTrackingUrl() throws
Exception {
proxyConn.getURL().toString().equals(appAddressInRm));
//set AHS_ENBALED = true to simulate getting the app report from AHS
- configuration.setBoolean(YarnConfiguration.APPLICATION_HISTORY_ENABLED,
- true);
+ configuration.setBoolean(YarnConfiguration.APPLICATION_HISTORY_ENABLED,
true);
+ proxy.proxy.appReportFetcher.setAhsAppPageUrlBase(configuration);
Review Comment:
Not sure why checkstyle complains about this.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java:
##########
@@ -375,8 +376,8 @@ public void testAppReportForEmptyTrackingUrl() throws
Exception {
String appAddressInAhs = WebAppUtils.getHttpSchemePrefix(configuration) +
WebAppUtils.getAHSWebAppURLWithoutScheme(configuration) +
"/applicationhistory" + "/app/" + app.toString();
- assertTrue("Webapp proxy servlet should have redirected to AHS",
- proxyConn.getURL().toString().equals(appAddressInAhs));
+ assertEquals("Webapp proxy servlet should have redirected to AHS",
appAddressInAhs,
Review Comment:
I think the indentation is broken here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
