steveloughran commented on code in PR #4753:
URL: https://github.com/apache/hadoop/pull/4753#discussion_r948983401
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java:
##########
@@ -182,6 +196,12 @@ protected Configuration createValidRoleConf() throws
JsonProcessingException {
return conf;
}
+ protected Configuration createValidRoleConfWithExternalId() throws
JsonProcessingException {
Review Comment:
why this method? on L160 its setting is completely overwritten
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java:
##########
@@ -152,6 +152,20 @@ public void testCreateCredentialProvider() throws
IOException {
}
}
+ @Test
+ public void testCreateCredentialProviderWithExternalId() throws IOException {
Review Comment:
how about a test where a known invalid id set, with the expectation of a
failure. that way wire up can be verified and a new stack trace for
troubleshooting.md/assumed_roles.md is created.
use `intercept()` to catch the exception by type, but don't include any
string match on the message text...that has turned out to be very brittle with
SDK updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
