attilapiros commented on code in PR #4728:
URL: https://github.com/apache/hadoop/pull/4728#discussion_r949572501
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestManifestCommitProtocol.java:
##########
@@ -1549,6 +1550,21 @@ public void testOutputFormatIntegration() throws
Throwable {
ManifestCommitter committer = (ManifestCommitter)
outputFormat.getOutputCommitter(tContext);
+ // check path capabilities directly
+ Assertions.assertThat(committer.hasCapability(
+ ManifestCommitterConstants.CAPABILITY_DYNAMIC_PARTITIONING))
+ .describedAs("dynamic partitioning capability in committer %s",
+ committer);
+ // and through a binding committer -passthrough is critical
+ // for the spark binding.
+ BindingPathOutputCommitter bindingCommitter =
+ new BindingPathOutputCommitter(outputDir, tContext);
+ Assertions.assertThat(bindingCommitter.hasCapability(
+ ManifestCommitterConstants.CAPABILITY_DYNAMIC_PARTITIONING))
+ .describedAs("dynamic partitioning capability in committer %s",
+ bindingCommitter);
Review Comment:
```suggestion
bindingCommitter).isTrue();
```
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestManifestCommitProtocol.java:
##########
@@ -1549,6 +1550,21 @@ public void testOutputFormatIntegration() throws
Throwable {
ManifestCommitter committer = (ManifestCommitter)
outputFormat.getOutputCommitter(tContext);
+ // check path capabilities directly
+ Assertions.assertThat(committer.hasCapability(
+ ManifestCommitterConstants.CAPABILITY_DYNAMIC_PARTITIONING))
+ .describedAs("dynamic partitioning capability in committer %s",
+ committer);
Review Comment:
```suggestion
committer).isTrue();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
