[ 
https://issues.apache.org/jira/browse/HADOOP-18382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581837#comment-17581837
 ] 

ASF GitHub Bot commented on HADOOP-18382:
-----------------------------------------

ahmarsuhail commented on PR #4698:
URL: https://github.com/apache/hadoop/pull/4698#issuecomment-1220638885

   @steveloughran have added a new V2Migration class and reverted using fully 
qualified classnames. Some deprecation warnings now, but they are all for 
imports. 
   
   For AWSCredentialProviderList, this is what I was thinking too. We can 
definitely prevent DT from breaking..but since usage is limited not sure if 
it's better to force people to update instead. have marked the class final for 
now. 
   
   there's also a patch warning on yetus now..not sure why? i'd merged trunk 
into this branch a couple of days ago. 




> Upgrade AWS SDK to V2 - Prerequisites 
> --------------------------------------
>
>                 Key: HADOOP-18382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18382
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ahmar Suhail
>            Assignee: Ahmar Suhail
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> We want to update the AWS SDK to V2, before we do this we should warn on 
> things that will no longer supported. The following changes should be made:
>  
>  * 
> [getAmazonS3Client()|https://github.com/apache/hadoop/blob/221eb2d68d5b52e4394fd36cb30d5ee9ffeea7f0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java#L1174]
>  - Warn that this method will be removed 
>  * 
> [initCustomSigners()|https://github.com/apache/hadoop/blob/03cfc852791c14fad39db4e5b14104a276c08e59/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerManager.java#L65]
>  - Warn that the interface is changing, any custom signers will need to be 
> updated
>  * 
> [bindAWSClient|https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java#L840]
>  - If DT is enabled, warn that credential providers interface is changing, 
> any custom cred providers used in binding classes will need to be updated
>  *  
> [buildAWSProviderList|https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java#L618]
>  - if any SDK V1 cred providers are in this list, warn that these will be 
> removed
>  * 
> [S3ClientFactory|https://github.com/apache/hadoop/blob/221eb2d68d5b52e4394fd36cb30d5ee9ffeea7f0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ClientFactory.java]
>  - Update javadocs to say this interface will be replaced by a V2 client 
> factory, mark interface deprecated?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to