[
https://issues.apache.org/jira/browse/HADOOP-18279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582003#comment-17582003
]
ASF GitHub Bot commented on HADOOP-18279:
-----------------------------------------
snmvaughan opened a new pull request, #4767:
URL: https://github.com/apache/hadoop/pull/4767
### Description of PR
The key stores factory starts a timer for monitoring file changes that
should be reloaded. The call to destroy() doesn't cancel the timer when a
trust manager isn't defined. This leaves the timer running, during shutdown.
This can be seen in unit tests that do not stop when the test completes.
### How was this patch tested?
Analysis of logs for tests that were timing out despite successfully
completing the test identified that the monitoring thread was still running.
With the addition of this change, these tests passed quickly.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Cancel fileMonitoringTimer even if trustManager isn't defined
> -------------------------------------------------------------
>
> Key: HADOOP-18279
> URL: https://issues.apache.org/jira/browse/HADOOP-18279
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, test
> Affects Versions: 3.4.0, 3.3.9
> Environment: This problem was identified using the Hadoop Development
> Environment during unit testing.
> Reporter: Steve Vaughan
> Assignee: Steve Vaughan
> Priority: Major
>
> The key stores factory starts a timer for monitoring file changes that should
> be reloaded. The call to destroy() doesn't cancel the timer when a trust
> manager isn't defined. This leaves the timer running, during shutdown. This
> can be seen in unit tests that do not stop when the test completes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
